ConfigurationInfo.java
- No need to import both a package and a class within that package, as
org.w3c.dom.* and org.w3c.dom.Document
- setFromXML and GetDirectoriesDelimited should be private methods. They are
not used by methods outside of this class, and reducing the interface of the
class will make for easier maintenance in the future. It also helps to clarify
the responsibilities of the class to its outside clients.
- there is a confusing amount of whitespace in the file
- Refactor to extract methods - some methods are too long to be easily
understood, like setFromXML() (100 lines) and xml() (88 lines)
- good extraction of common code from getUploadDirectoriesDelimited and
getDownloadDirectoriesDelimited
- inconsistent commenting
- "temporary routine" (from coment) PopulateMP() should be removed or at
least made private.
- good use of static strings for xml names. Could go further and make them
final as well.
- //TODO: load music profiles -this feature is still unimplemented
- xml() method - "return "<error/>";" could go into catch block, to be more
explicit about what's going on.